Add HfFileSystem.url method
#2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2027 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 66 66
Lines 8240 8249 +9
==========================================
+ Hits 6788 6795 +7
- Misses 1452 1454 +2 ☔ View full report in Codecov by Sentry. |
Wauplin
approved these changes
Feb 15, 2024
Co-authored-by: Lucain <lucainp@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Wauplin
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
urlmethod to theHfFileSystemto simplify converting HF paths to HTTP URLs, which should be useful when working with libs that support HTTP URLs but notfsspecpaths as input/output (e.g.,webdataset,polars, etc.).PS: The
urlmethod is not part of the officialfsspecspecification, but popular filesystem implementations such asgcsfsands3fsalso have it